linux-kernel - Re: [PATCH -v2 12/13] x86, mm: Use func pointer to table size calculation and mapping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Sep 2012 23:21:01 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>, Jacob Shin <jacob.shin@....com>,
	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -v2 12/13] x86, mm: Use func pointer to table size
 calculation and mapping.

On Sun, Sep 2, 2012 at 10:43 PM, Pekka Enberg <penberg@...nel.org> wrote:
> On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu <yinghai@...nel.org> wrote:
>> +static void __init with_all_ram_ranges(
>> +                       void (*work_fn)(unsigned long, unsigned long, void *),
>> +                       void *data)
>
>> +static void __init size_work_fn(unsigned long start, unsigned long end, void *data)
>
>> +static void __init mapping_work_fn(unsigned long start, unsigned long end,
>> +                                        void *data)
>
> So I passionately hate the naming convention. How about something
> similar to mm/pagewalk.c:
>
>   s/with_all_ram_ranges/walk_ram_ranges/g

ok.

>
>   s/size_work_fn/table_space_size/g
>
>   s/mapping_work_fn/map_memory/g

I would prefer simple one size_work_fn, and mapping_working_fn.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/