linux-kernel - Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120904161330.GA20588@linux.vnet.ibm.com>
Date:	Tue, 4 Sep 2012 11:13:30 -0500
From:	Kent Yoder <key@...ux.vnet.ibm.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	James Morris <jmorris@...ei.org>, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	tpmdd-devel@...ts.sourceforge.net, kernel-janitors@...r.kernel.org,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address
 spaces

On Sun, Sep 02, 2012 at 09:30:30AM -0700, Dan Carpenter wrote:
> Sparse finds that bug as well.  ;)
> 
> drivers/acpi/acpica/tbfadt.c:247:15: warning: incorrect type in assignment (different address spaces)
> drivers/acpi/acpica/tbfadt.c:247:15:    expected struct acpi_table_header *table
> drivers/acpi/acpica/tbfadt.c:247:15:    got void [noderef] <asn:2>*
> drivers/acpi/acpica/tbfadt.c:266:30: warning: incorrect type in argument 1 (different address spaces)
> drivers/acpi/acpica/tbfadt.c:266:30:    expected void [noderef] <asn:2>*logical_address
> drivers/acpi/acpica/tbfadt.c:266:30:    got struct acpi_table_header *table
> 
> It should be memcpy_fromio() probably.

  Thanks Dan, that's clearly better. James, I'll resubmit this one
today.

Thanks,
Kent

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/