linux-kernel - Re: [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120904163608.GB14382@mit.edu>
Date:	Tue, 4 Sep 2012 09:36:09 -0700
From:	Silas Boyd-Wickizer <sbw@....edu>
To:	Rusty Russell <rusty@....ibm.com>
Cc:	linux-kernel@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU
 hotplug

Hi Rusty,

I used libsparse and kernel source annotations to check that code uses
for_each_online_cpu in contexts with hotplug disabled
(e.g. get_online_cpus(), preempt_disable, ..).  I compiled with an x86
64-bit allyesconfig, so I missed other architecture specific usages.
The checker code isn't great and the results still require some manual
inspection for weeding out false positives, etc:

  http://pdos.csail.mit.edu/~sbw/online-checker/

Silas

On Thu, Aug 30, 2012 at 06:02:11AM +0930, Rusty Russell wrote:
> Silas Boyd-Wickizer <sbw@....edu> writes:
> 
> > Hello,
> >
> > This is the second version of the patches to fix races described in:
> >
> >   https://groups.google.com/forum/?fromgroups#!topic/linux.kernel/iSUDr94Qehc
> >
> > The changes in this version are:
> >
> >   * fix commit log typo;
> >   * prevent a race in via_cputemp_exit;
> >   * and a new patch that prevents races during init/exit in
> >     drivers/hwmon/coretemp.c.
> 
> Hi Silas,
> 
>         Good work! How did you find these?
> 
> Cheers,
> Rusty.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/