linux-kernel - Re: [PATCH 2/3] staging/vme: Use pr_ printks in vme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120904202053.GA23449@kroah.com>
Date:	Tue, 4 Sep 2012 13:20:53 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Toshiaki Yamane <yamanetoshi@...il.com>
Cc:	devel@...verdev.osuosl.org,
	Manohar Vanga <manohar.vanga@...il.com>,
	linux-kernel@...r.kernel.org, Martyn Welch <martyn.welch@...com>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH 2/3] staging/vme: Use pr_ printks in vme_user.c

On Tue, Aug 21, 2012 at 08:12:53PM +0900, Toshiaki Yamane wrote:
> The below checkpatch warnings was fixed,
> 
> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
> -WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
> -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
> -WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
> 
> and added pr_fmt.

A lot of these can be converted to use dev_info(), dev_debug(),
dev_warn(), and dev_err() instead.  Please do that whenever you have
access to a struct device.

So, sorry, I can't take this patch.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/