linux-kernel - Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120904230117.5a44eb89@pyramind.ukuu.org.uk>
Date:	Tue, 4 Sep 2012 23:01:17 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, rdunlap@...otime.net,
	arve@...roid.com, kernel-team@...roid.com, john.stultz@...aro.org
Subject: Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in
 sysRQ

> which brings us to the "reset_fn()" function - in my opinion it offers
> significant advantages and should be kept in the design.  What I'm not
> so clear about is on the implementation.  Should it be kept as part of a
> platform data or be implemented as a notifier as suggested by Alan.  I
> am looking for guidance here and suggestions are encouraged.

Not sure reset_fn is the best name but it'll do for me. As for things like
notifiers, thats extra complexity. *When* someone needs it then they can
add it. We don't need to add extra complexity now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/