linux-kernel - Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120904225917.GB3725@kroah.com>
Date:	Tue, 4 Sep 2012 15:59:17 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, ben@...adent.org.uk,
	thozza@...hat.com, dcbw@...hat.com
Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve
 dhcp state

On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote:
> To keep the KVP daemon code free of distro specific details, we invoke an
> external script to retrieve the DHCP state. This is an example script that
> was used to test the KVP code. This script has to be implemented in a Distro
> specific fashion. For instance on distros that ship with Network Manager enabled,
> this script can be based on NM APIs.
> 
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
>  tools/hv/hv_get_dhcp_info.sh |   25 +++++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)
>  create mode 100755 tools/hv/hv_get_dhcp_info.sh
> 
> diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh
> new file mode 100755
> index 0000000..3de4587
> --- /dev/null
> +++ b/tools/hv/hv_get_dhcp_info.sh
> @@ -0,0 +1,25 @@
> +#!/bin/bash
> +
> +# This example script retrieves the DHCP state of a given interface.
> +# In the interest of keeping the KVP daemon code free of distro specific
> +# information; the kvp daemon code invokes this external script to gather
> +# DHCP setting for the specific interface.
> +#
> +# Input: Name of the interface
> +#
> +# Output: The script prints the string "Enabled" to stdout to indicate
> +#	that DHCP is enabled on the interface.

What happens if DHCP is not enabled on the interface?  Shouldn't that
also return something other than "success"?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/