[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1346746632-3025128-1-git-send-email-avagin@openvz.org>
Date: Tue, 4 Sep 2012 12:17:12 +0400
From: Andrew Vagin <avagin@...nvz.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: criu@...nvz.org, linux-kernel@...r.kernel.org, avagin@...nvz.org,
Andrew Morton <akpm@...ux-foundation.org>,
Oleg Nesterov <oleg@...hat.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Pavel Emelyanov <xemul@...allels.com>
Subject: [PATCH] kernel: limit a value of ns_last_pid to (0, max_pid)
The kernel doesn't check pid on a negative values, so if
you would try to write -2 in /proc/sys/kernel/ns_last_pid,
you will get a kernel panic.
In this case the next pid is -1, and alloc_pidmap will try to access
to a nonexistent pidmap.
map = &pid_ns->pidmap[pid/BITS_PER_PAGE];
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Oleg Nesterov <oleg@...hat.com>
Cc: Eric W. Biederman <ebiederm@...ssion.com>
Cc: Pavel Emelyanov <xemul@...allels.com>
Acked-by: Cyrill Gorcunov <gorcunov@...nvz.org>
Signed-off-by: Andrew Vagin <avagin@...nvz.org>
---
kernel/pid_namespace.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
index b3c7fd5..6144bab 100644
--- a/kernel/pid_namespace.c
+++ b/kernel/pid_namespace.c
@@ -232,15 +232,19 @@ static int pid_ns_ctl_handler(struct ctl_table *table, int write,
*/
tmp.data = ¤t->nsproxy->pid_ns->last_pid;
- return proc_dointvec(&tmp, write, buffer, lenp, ppos);
+ return proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos);
}
+extern int pid_max;
+static int zero = 0;
static struct ctl_table pid_ns_ctl_table[] = {
{
.procname = "ns_last_pid",
.maxlen = sizeof(int),
.mode = 0666, /* permissions are checked in the handler */
.proc_handler = pid_ns_ctl_handler,
+ .extra1 = &zero,
+ .extra2 = &pid_max,
},
{ }
};
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists