[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120905054830.GB7517@redhat.com>
Date: Wed, 5 Sep 2012 08:48:30 +0300
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Asias He <asias@...hat.com>
Cc: Rusty Russell <rusty@...tcorp.com.au>,
Kent Overstreet <koverstreet@...gle.com>,
linux-kernel@...r.kernel.org,
virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] virtio-blk: Fix kconfig option
On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote:
> On 09/04/2012 02:23 PM, Rusty Russell wrote:
> > Kent Overstreet <koverstreet@...gle.com> writes:
> >
> >> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it
> >> instead.
> >
> > This is a slight mis-understanding. It's supposed to be selected by
> > the particular driver, probably virtio_pci in your case.
>
> virtio_mmio selects virtio as well.
>
> drivers/virtio/Kconfig
> config VIRTIO_MMIO
> select VIRTIO
> config VIRTIO_PCI
> select VIRTIO
>
> How about this:
> config VIRTIO_BLK
> depends on EXPERIMENTAL && (VIRTIO_PCI || VIRTIO_MMIO)
Isn't this exactly what depends on VIRTIO achieves?
> --
> Asias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists