linux-kernel - Re: [PATCH] ALSA: use list_move_tail instead of list_del/list_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h7gs8kjcy.wl%tiwai@suse.de>
Date:	Wed, 05 Sep 2012 09:40:45 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	perex@...ex.cz, yongjun_wei@...ndmicro.com.cn,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: use list_move_tail instead of list_del/list_add_tail

At Wed, 5 Sep 2012 15:00:15 +0800,
Wei Yongjun wrote:
> 
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Applied this one, too.  Thanks.


Takashi


> ---
>  sound/pci/emu10k1/memory.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c
> index 0a43662..1dce0a39 100644
> --- a/sound/pci/emu10k1/memory.c
> +++ b/sound/pci/emu10k1/memory.c
> @@ -263,8 +263,8 @@ int snd_emu10k1_memblk_map(struct snd_emu10k1 *emu, struct snd_emu10k1_memblk *b
>  	spin_lock_irqsave(&emu->memblk_lock, flags);
>  	if (blk->mapped_page >= 0) {
>  		/* update order link */
> -		list_del(&blk->mapped_order_link);
> -		list_add_tail(&blk->mapped_order_link, &emu->mapped_order_link_head);
> +		list_move_tail(&blk->mapped_order_link,
> +			       &emu->mapped_order_link_head);
>  		spin_unlock_irqrestore(&emu->memblk_lock, flags);
>  		return 0;
>  	}
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/