linux-kernel - Re: [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1209051156560.11079@pobox.suse.cz>
Date:	Wed, 5 Sep 2012 11:57:36 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Axel Lin <axel.lin@...il.com>
Cc:	Chris Schlund <chrisschlund@....de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard
 coded 0x0ffbc0000

On Wed, 5 Sep 2012, Axel Lin wrote:

> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/hid/hid-lcpower.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-lcpower.c b/drivers/hid/hid-lcpower.c
> index c4fe9bd0..22bc14a 100644
> --- a/drivers/hid/hid-lcpower.c
> +++ b/drivers/hid/hid-lcpower.c
> @@ -24,7 +24,7 @@ static int ts_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  		struct hid_field *field, struct hid_usage *usage,
>  		unsigned long **bit, int *max)
>  {
> -	if ((usage->hid & HID_USAGE_PAGE) != 0x0ffbc0000)
> +	if ((usage->hid & HID_USAGE_PAGE) != HID_UP_LOGIVENDOR)
>  		return 0;
>  
>  	switch (usage->hid & HID_USAGE) {

The name of the actual constant is quite losing its point with more and 
more non-Logitech devices using this usage page.

I am applying your patch now, but I guess we'll rather rename the define 
in a near future.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/