[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <tip-5c7d03e99cb1ed449328ed9fba0c632944d39e7e@git.kernel.org>
Date: Wed, 5 Sep 2012 03:58:13 -0700
From: tip-bot for Mathias Krause <minipli@...glemail.com>
To: linux-tip-commits@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
minipli@...glemail.com, suresh.b.siddha@...el.com,
tglx@...utronix.de
Subject: [tip:x86/debug] x86/fpu/xsave: Keep __user annotation in casts
Commit-ID: 5c7d03e99cb1ed449328ed9fba0c632944d39e7e
Gitweb: http://git.kernel.org/tip/5c7d03e99cb1ed449328ed9fba0c632944d39e7e
Author: Mathias Krause <minipli@...glemail.com>
AuthorDate: Sun, 2 Sep 2012 23:31:44 +0200
Committer: Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 5 Sep 2012 10:52:25 +0200
x86/fpu/xsave: Keep __user annotation in casts
Don't remove the __user annotation of the fpstate pointer, but
drop the superfluous void * cast instead.
This fixes the following sparse warnings:
xsave.c:135:15: warning: cast removes address space of expression
xsave.c:135:15: warning: incorrect type in argument 1 (different address spaces)
xsave.c:135:15: expected void const volatile [noderef] <asn:1>*<noident>
[...]
Signed-off-by: Mathias Krause <minipli@...glemail.com>
Cc: Suresh Siddha <suresh.b.siddha@...el.com>
Link: http://lkml.kernel.org/r/1346621506-30857-6-git-send-email-minipli@googlemail.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
arch/x86/kernel/xsave.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/xsave.c b/arch/x86/kernel/xsave.c
index 3d3e207..9e1a8a7 100644
--- a/arch/x86/kernel/xsave.c
+++ b/arch/x86/kernel/xsave.c
@@ -132,9 +132,9 @@ int check_for_xstate(struct i387_fxsave_struct __user *buf,
fx_sw_user->xstate_size > fx_sw_user->extended_size)
return -EINVAL;
- err = __get_user(magic2, (__u32 *) (((void *)fpstate) +
- fx_sw_user->extended_size -
- FP_XSTATE_MAGIC2_SIZE));
+ err = __get_user(magic2, (__u32 __user *) (fpstate +
+ fx_sw_user->extended_size -
+ FP_XSTATE_MAGIC2_SIZE));
if (err)
return err;
/*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists