linux-kernel - Re: [PATCH v2] checkpatch: Suggest using min_t or max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOoYnzLViwqp11Tw1zf0C+qhc+AtzefNLzZEbC2oUPkWPV5zqQ@mail.gmail.com>
Date:	Wed, 5 Sep 2012 13:21:50 +0200
From:	Philippe De Muyter <philippe.demuyter@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] checkpatch: Suggest using min_t or max_t

On 5/27/11, Joe Perches <joe@...ches.com> wrote:
> A common issue with min() or max() is using a cast on
> one or both of the arguments when using min_t/max_t could
> be better.
>
> Add cast detection to uses of min/max and suggest an
> appropriate use of min_t or max_t instead.
>
> Caveat:  This only works for min() or max() on a single line.
>          It does not find min() or max() split across multiple lines.
>
> This does find:
> 	min((u32)foo, bar);
> But it does not find:
> 	max((unsigned long)foo,
> 	    bar);
>
> Suggested-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>
> v2: Make $match_balanced_parentheses work in perl 5.8

Has this been applied  ?

v3.3 version of checkpatch.pl works for me, but v3.4, v3.5 & v3.6rc2 say:
Nested quantifiers in regex; marked by <-- HERE in m/(\((?:[^\(\)]++
<-- HERE |(?-1))*\))/ at scripts/checkpatch.pl line 340.

and my perl is :

        perl --version

        This is perl, v5.8.8 built for i586-linux-thread-multi

Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/