linux-kernel - Re: [PATCH 02/10 V4] workqueue: fix deadlock in rebind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120905013347.GF2836@dhcp-172-17-108-109.mtv.corp.google.com>
Date:	Tue, 4 Sep 2012 18:33:47 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10 V4] workqueue: fix deadlock in rebind_workers()

Hello,

On Wed, Sep 05, 2012 at 09:28:38AM +0800, Lai Jiangshan wrote:
> I see that this patch's idea is same as mine but reuses
> @idle_rebind.cnt and @idle_rebind.done.
> 
> I don't think it is consistent to avoid adding new field
> and to reuse old field for different purpose

It's not necessarily the reuse which seems more consistent to me but
where the driving logic is.  It's now better contained in
rebind_workers().

> > -	/*
> > -	 * All idle workers are rebound and waiting for %WORKER_REBIND to
> > -	 * be cleared inside idle_worker_rebind().  Clear and release.
> > -	 * Clearing %WORKER_REBIND from this foreign context is safe
> > -	 * because these workers are still guaranteed to be idle.
> > -	 */
> > -	for_each_worker_pool(pool, gcwq)
> > -		list_for_each_entry(worker, &pool->idle_list, entry)
> > -			worker->flags &= ~WORKER_REBIND;
> > -
> > -	wake_up_all(&gcwq->rebind_hold);
> 
> don't need to move down.

Yeap, but cleaner that way.  With the moving separated into another
patch, the addition of another handshake stage becomes easier to
follow.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/