[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120905000419.GC31997@kroah.com>
Date: Tue, 4 Sep 2012 17:04:19 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: KY Srinivasan <kys@...rosoft.com>
Cc: "olaf@...fle.de" <olaf@...fle.de>,
"thozza@...hat.com" <thozza@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dcbw@...hat.com" <dcbw@...hat.com>,
"apw@...onical.com" <apw@...onical.com>,
"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
"ben@...adent.org.uk" <ben@...adent.org.uk>
Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve
dhcp state
On Tue, Sep 04, 2012 at 11:39:12PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > Sent: Tuesday, September 04, 2012 6:59 PM
> > To: KY Srinivasan
> > Cc: linux-kernel@...r.kernel.org; devel@...uxdriverproject.org; olaf@...fle.de;
> > apw@...onical.com; ben@...adent.org.uk; thozza@...hat.com;
> > dcbw@...hat.com
> > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp
> > state
> >
> > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote:
> > > To keep the KVP daemon code free of distro specific details, we invoke an
> > > external script to retrieve the DHCP state. This is an example script that
> > > was used to test the KVP code. This script has to be implemented in a Distro
> > > specific fashion. For instance on distros that ship with Network Manager
> > enabled,
> > > this script can be based on NM APIs.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > > Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > > ---
> > > tools/hv/hv_get_dhcp_info.sh | 25 +++++++++++++++++++++++++
> > > 1 files changed, 25 insertions(+), 0 deletions(-)
> > > create mode 100755 tools/hv/hv_get_dhcp_info.sh
> > >
> > > diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh
> > > new file mode 100755
> > > index 0000000..3de4587
> > > --- /dev/null
> > > +++ b/tools/hv/hv_get_dhcp_info.sh
> > > @@ -0,0 +1,25 @@
> > > +#!/bin/bash
> > > +
> > > +# This example script retrieves the DHCP state of a given interface.
> > > +# In the interest of keeping the KVP daemon code free of distro specific
> > > +# information; the kvp daemon code invokes this external script to gather
> > > +# DHCP setting for the specific interface.
> > > +#
> > > +# Input: Name of the interface
> > > +#
> > > +# Output: The script prints the string "Enabled" to stdout to indicate
> > > +# that DHCP is enabled on the interface.
> >
> > What happens if DHCP is not enabled on the interface? Shouldn't that
> > also return something other than "success"?
>
> The script is expected to write "Enabled" to stdout to indicate if DHCP is enabled; if this
> is not the case, implicitly we assume DHCP is not enabled (since this is a binary state).
It's not really "binary" given that you are expecting "Enabled" or
nothing, right? "Disabled" would make a bit more sense perhaps?
Having a script return "nothing at all" to show the failure of a state
doesn't seem the wisest thing, does it?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists