linux-kernel - Re: [RFC v2 PATCH 1/7] thp: remove assumptions on pgtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 5 Sep 2012 19:12:13 +0200
From:	Gerald Schaefer <gerald.schaefer@...ibm.com>
To:	Andrea Arcangeli <aarcange@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Hugh Dickins <hughd@...gle.com>,
	Hillf Danton <dhillf@...il.com>, linux-kernel@...r.kernel.org,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: [RFC v2 PATCH 1/7] thp: remove assumptions on pgtable_t type

On Wed, 5 Sep 2012 00:56:33 +0200
Andrea Arcangeli <aarcange@...hat.com> wrote:

> Hi Gerald,
> 
> On Wed, Aug 29, 2012 at 05:32:58PM +0200, Gerald Schaefer wrote:
> > +#ifndef __HAVE_ARCH_PGTABLE_DEPOSIT
> > +extern void pgtable_deposit(struct mm_struct *mm, pgtable_t pgtable);
> > +#endif
> 
> One minor nitpick on the naming of the two functions: considering that
> those are global exports, that they can only be used by THP and they
> mangle internally with the mm->pmd_huge_pte field (also only defined
> if TRANSPARENT_HUGEPAGE=y), a more specific THP naming may be clearer.
> 
> If the current prepare_pmd_huge_pte/get_pmd_huge_pte wasn't good other
> options could be pgtable_trans_huge_deposit/withdraw.
> 

Thanks for your feedback. I'll send a new patch series with those
functions renamed, as it has impact on 3 of the 7 patches, and also
including the Kconfig change using HAVE_ARCH_TRANSPARENT_HUGEPAGE.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/