[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120905022932.GA4087@srcf.ucam.org>
Date: Wed, 5 Sep 2012 03:29:32 +0100
From: Matthew Garrett <mjg@...hat.com>
To: Don Dutile <ddutile@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
linux-efi@...r.kernel.org, mfleming@...el.com, dwmw2@...radead.org,
bhelgaas@...gle.com
Subject: Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs
On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote:
> > /*
> >+ * Some devices may provide ROMs via a source other than the BAR
> >+ */
> >+ if (pdev->rom&& pdev->romlen) {
> >+ *size = pdev->romlen;
> >+ return phys_to_virt((phys_addr_t)pdev->rom);
> ^^^^^
> ioremap_nocache() ? ... or is caching rom ok?
If it's appearing through this pathway then it's not actually in ROM,
the platform has pulled it out of somewhere else.
--
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists