linux-kernel - Re: [PATCH 2/5] drivers/media/platform/s5p-tv/sdo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALF0-+VRin4LrR-9zuXro2MJ2wePkw40SSD=vrqrsrSFTsgSAg@mail.gmail.com>
Date:	Wed, 5 Sep 2012 16:33:10 -0300
From:	Ezequiel Garcia <elezegarcia@...il.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	kernel-janitors@...r.kernel.org, Julia.Lawall@...6.fr,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] drivers/media/platform/s5p-tv/sdo_drv.c: fix error
 return code

Hi Peter,

On Tue, Sep 4, 2012 at 1:14 PM, Peter Senna Tschudin
<peter.senna@...il.com> wrote:
> From: Peter Senna Tschudin <peter.senna@...il.com>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
>
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
>
> ---
>  drivers/media/platform/s5p-tv/sdo_drv.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c
> index ad68bbe..58cf56d 100644
> --- a/drivers/media/platform/s5p-tv/sdo_drv.c
> +++ b/drivers/media/platform/s5p-tv/sdo_drv.c
> @@ -369,6 +369,7 @@ static int __devinit sdo_probe(struct platform_device *pdev)
>         sdev->fout_vpll = clk_get(dev, "fout_vpll");
>         if (IS_ERR_OR_NULL(sdev->fout_vpll)) {
>                 dev_err(dev, "failed to get clock 'fout_vpll'\n");
> +               ret = -ENODEV;
>                 goto fail_dacphy;
>         }
>         dev_info(dev, "fout_vpll.rate = %lu\n", clk_get_rate(sclk_vpll));
> @@ -377,11 +378,13 @@ static int __devinit sdo_probe(struct platform_device *pdev)
>         sdev->vdac = devm_regulator_get(dev, "vdd33a_dac");
>         if (IS_ERR_OR_NULL(sdev->vdac)) {
>                 dev_err(dev, "failed to get regulator 'vdac'\n");
> +               ret = -ENODEV;
>                 goto fail_fout_vpll;
>         }
>         sdev->vdet = devm_regulator_get(dev, "vdet");
>         if (IS_ERR_OR_NULL(sdev->vdet)) {
>                 dev_err(dev, "failed to get regulator 'vdet'\n");
> +               ret = -ENODEV;
>                 goto fail_fout_vpll;
>         }
>
>

Just a nitpick: why using ENODEV when the rest of the function is using ENXIO?
In which case, you could fix this with a less intrusive change, by
initializating ret to -ENXIO.

Hope this helps,
Ezequiel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/