linux-kernel - Re: [PATCH 0/4] Tools: hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120905193852.GA412@kroah.com>
Date:	Wed, 5 Sep 2012 12:38:52 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	KY Srinivasan <kys@...rosoft.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>,
	"thozza@...hat.com" <thozza@...hat.com>,
	"dcbw@...hat.com" <dcbw@...hat.com>
Subject: Re: [PATCH 0/4] Tools: hv

On Wed, Sep 05, 2012 at 07:24:37PM +0000, KY Srinivasan wrote:
> > On Wed, Sep 05, 2012 at 10:01:59AM -0700, K. Y. Srinivasan wrote:
> > > This patchset was authored by Ben Hutchings <ben@...adent.org.uk>. Ben
> > > asked me to submit this patchset. This patchset cleans up the KVP daemon
> > > code and fixes some bugs.
> > >
> > >
> > > K. Y. Srinivasan (4):
> > >   tools: hv: Fix file handle leak
> > >   tools: hv: Fix exit() error code
> > >   tools: hv: Check for read/write errors
> > >   tools: hv: Parse /etc/os-release
> > 
> > If Ben wrote these, why are you showing that you wrote them?
> 
> Ben asked me to apply these patches on the tip (of my tree) and send the
> patches out and that is what I did. I recreated these patches after applying to
> my tree and that is what I have sent out. How could I have made the authorship
> more clear (other than noting so in the comment which I have done).

You could have actually _kept_ the proper authorship information so that
git shows who wrote the patch.  As your shortlog shows above, it looks
like you wrote the patches, not Ben, which is not acceptable.

As to how to actually do that, well, I'll leave that as an exercise for
the reader (hint, we document how to do this quite well...)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/