linux-kernel - Re: [PATCH 10/11 V5] workqueue: unbind/rebind without manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120905200411.GD13737@google.com>
Date:	Wed, 5 Sep 2012 13:04:11 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11 V5] workqueue: unbind/rebind without manager_mutex

Hello, Lai.

On Wed, Sep 05, 2012 at 06:37:47PM +0800, Lai Jiangshan wrote:
> gcwq_unbind_fn() unbind manager by ->manager pointer.
> 
> rebinding-manger, unbinding/rebinding newly created worker are done by
> other place. so we don't need manager_mutex any more.
> 
> Also change the comment of @bind accordingly.

Please don't scatter small prep patches like this.  Each piece in
isolation doesn't make much sense to me and the patch descriptions
don't help much.  Please collect the prep patches and explain in more
detail.

In general, I'm not sure about this approach.  I'd really like the
hotplug logic to be contained in hotplug logic proper as much as
possible.  This scatters around hotplug handling to usual code paths
and seems too invasive for 3.6-fixes.

Also, can you please talk to me before going ahead and sending me
completely new 10 patch series every other day?  You're taking
disproportionate amount of my time and I can't continue to do this.
Please discuss with me or at least explain the high-level approach in
the head message in detail.  Going through the patch series to figure
out high-level design which is constantly flipping is rather
inefficient and unfortunately your patch descriptions aren't too
helpful.  :(

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/