[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120905.173118.1107211725393320514.davem@davemloft.net>
Date: Wed, 05 Sep 2012 17:31:18 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: nicolas.ferre@...el.com
Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
havard@...nnemoen.net, plagnioj@...osoft.com, jamie@...ieiles.com,
linux-kernel@...r.kernel.org, patrice.vilchez@...el.com
Subject: Re: [PATCH 08/10] net/macb: macb_get_drvinfo: add GEM/MACB suffix
to differentiate revision
From: Nicolas Ferre <nicolas.ferre@...el.com>
Date: Wed, 5 Sep 2012 11:00:53 +0200
> strcpy(info->driver, bp->pdev->dev.driver->name);
> + if (macb_is_gem(bp))
> + strcat(info->driver, " GEM");
> + else
> + strcat(info->driver, " MACB");
This is a driver string, which means the software driver, and has
absolutely nothing to do with the exact type of the underlying
physical hardware.
Therefore the these suffixes should be left out of the driver string.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists