[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1346887671.5325.47.camel@bwh-desktop.uk.solarflarecom.com>
Date: Thu, 6 Sep 2012 00:27:51 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: Nicolas Ferre <nicolas.ferre@...el.com>
CC: <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<davem@...emloft.net>, <havard@...nnemoen.net>,
<plagnioj@...osoft.com>, <jamie@...ieiles.com>,
<linux-kernel@...r.kernel.org>, <patrice.vilchez@...el.com>
Subject: Re: [PATCH 08/10] net/macb: macb_get_drvinfo: add GEM/MACB suffix
to differentiate revision
On Wed, 2012-09-05 at 11:00 +0200, Nicolas Ferre wrote:
> Add an indication about which revision of the hardware we are running in
> info->driver string.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
> ---
> drivers/net/ethernet/cadence/macb.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index bd331fd..c7c39f1 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1313,6 +1313,10 @@ static void macb_get_drvinfo(struct net_device *dev,
> struct macb *bp = netdev_priv(dev);
>
> strcpy(info->driver, bp->pdev->dev.driver->name);
> + if (macb_is_gem(bp))
> + strcat(info->driver, " GEM");
> + else
> + strcat(info->driver, " MACB");
> strcpy(info->version, "$Revision: 1.14 $");
Related to hardware revisions (which don't belong here, as David said),
I rather doubt this CVS ID is very useful as a driver version.
If the driver doesn't have a meaningful version (aside from the kernel
version) then you can remove this function and let the ethtool core fill
in the other two fields automatically.
Ben.
> strcpy(info->bus_info, dev_name(&bp->pdev->dev));
> }
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists