| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1346926091-3654-1-git-send-email-abbotti@mev.co.uk> Date: Thu, 6 Sep 2012 11:08:11 +0100 From: Ian Abbott <abbotti@....co.uk> To: lkml <linux-kernel@...r.kernel.org> Cc: linux-fsdevel@...r.kernel.org, Jan Kara <jack@...e.cz>, Ian Abbott <abbotti@....co.uk> Subject: [PATCH] UDF: Fix incorrect error handling in udf_direct_IO() My recent patch to add DIRECT_IO support to the UDF filesystem handler contains a mistake in the error recovery if blockdev_direct_IO() fails. The test `rw && WRITE` should be `rw & WRITE`. Fix it. Signed-off-by: Ian Abbott <abbotti@....co.uk> --- fs/udf/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index b905448..41d5830 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -156,7 +156,7 @@ static ssize_t udf_direct_IO(int rw, struct kiocb *iocb, ret = blockdev_direct_IO(rw, iocb, inode, iov, offset, nr_segs, udf_get_block); - if (unlikely(ret < 0 && (rw && WRITE))) + if (unlikely(ret < 0 && (rw & WRITE))) udf_write_failed(mapping, offset + iov_length(iov, nr_segs)); return ret; } -- 1.7.12 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists