[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdUXvB8P9J26KbMXeicv0BH=gdaCHaRq-ZAP=73hn+ThMw@mail.gmail.com>
Date: Thu, 6 Sep 2012 14:03:27 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Jean Delvare <khali@...ux-fr.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Finn Thain <fthain@...egraphics.com.au>
Subject: Re: [PATCH] swim: Add missing spinlock init
On Thu, Sep 6, 2012 at 1:48 PM, Jean Delvare <khali@...ux-fr.org> wrote:
> It doesn't seem this spinlock was properly initialized.
Quiet possible. There's no SMP on m68k, so all spinlock ops expand to nothing.
> Signed-off-by: Jean Delvare <khali@...ux-fr.org>
> Cc: Finn Thain <fthain@...egraphics.com.au>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> I can't even build-test this.
>
> drivers/block/swim.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-3.6-rc4.orig/drivers/block/swim.c 2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.6-rc4/drivers/block/swim.c 2012-09-06 13:09:26.713382169 +0200
> @@ -845,6 +845,7 @@ static int __devinit swim_floppy_init(st
> swd->unit[drive].swd = swd;
> }
>
> + spin_lock_init(&swd->lock);
> swd->queue = blk_init_queue(do_fd_request, &swd->lock);
> if (!swd->queue) {
> err = -ENOMEM;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists