linux-kernel - Re: Check all returns from audit_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120906155616.GB27399@redhat.com>
Date:	Thu, 6 Sep 2012 11:56:16 -0400
From:	Dave Jones <davej@...hat.com>
To:	Eric Paris <eparis@...isplace.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>, eparis@...hat.com
Subject: Re: Check all returns from audit_log_start

On Thu, Sep 06, 2012 at 11:47:49AM -0400, Dave Jones wrote:
 > > Not certain because I haven't looked at what happens with the error
 > > code, but I think this might not be right.  auditd can be explictly
 > > told not to audit certain events, in which case it is normal and
 > > expected that ab would come back NULL....
 > 
 > Ugh, that's a lot messier to have to audit every function that gets
 > passed 'ab' to make sure it has a NULL check, but ok I'll go look at it.
 > 
 > hopefully audit_log_link_denied was a one off.

ok, from a quick look-over, that does seem to be the case.
This still feels like a nasty trap waiting for someone to walk into again though.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/