linux-kernel - Re: [PATCH tip/core/rcu 14/23] rcu: Remove now-unused rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120906180251.GO2448@linux.vnet.ibm.com>
Date:	Thu, 6 Sep 2012 11:02:51 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, josh@...htriplett.org,
	niv@...ibm.com, tglx@...utronix.de, rostedt@...dmis.org,
	Valdis.Kletnieks@...edu, dhowells@...hat.com,
	eric.dumazet@...il.com, darren@...art.com, fweisbec@...il.com,
	sbw@....edu, patches@...aro.org
Subject: Re: [PATCH tip/core/rcu 14/23] rcu: Remove now-unused rcu_state
 fields

On Thu, Sep 06, 2012 at 04:17:03PM +0200, Peter Zijlstra wrote:
> On Thu, 2012-08-30 at 11:18 -0700, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> > 
> > Moving the RCU grace-period processing to a kthread and adjusting the
> > tracing resulted in two of the rcu_state structure's fields being unused.
> > This commit therefore removes them.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > ---
> >  kernel/rcutree.h |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> > 
> > diff --git a/kernel/rcutree.h b/kernel/rcutree.h
> > index 2d4cc18..8f0293c 100644
> > --- a/kernel/rcutree.h
> > +++ b/kernel/rcutree.h
> > @@ -378,13 +378,6 @@ struct rcu_state {
> >  
> >  	u8	fqs_state ____cacheline_internodealigned_in_smp;
> >  						/* Force QS state. */
> > -	u8	fqs_active;			/* force_quiescent_state() */
> > -						/*  is running. */
> > -	u8	fqs_need_gp;			/* A CPU was prevented from */
> > -						/*  starting a new grace */
> > -						/*  period because */
> > -						/*  force_quiescent_state() */
> > -						/*  was running. */
> >  	u8	boost;				/* Subject to priority boost. */
> >  	unsigned long gpnum;			/* Current gp number. */
> >  	unsigned long completed;		/* # of last completed gp. */
> 
> Typically one would fold this change into the patch that caused said
> redundancy and not mention it. Save a patch to (post/review/merge) and
> makes the patches a more solid whole.

Fair enough.  I still like the idea of pulling the stuff creating
rcu_gp_kthread() into one patch, though.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/