[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120906201538.GK29092@google.com>
Date: Thu, 6 Sep 2012 13:15:38 -0700
From: Tejun Heo <tj@...nel.org>
To: Bruno Prémont <bonbons@...ux-vserver.org>
Cc: Emil Goode <emilgoode@...il.com>, jkosina@...e.cz,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] HID: picoLCD: Remove use of deprecated function
On Thu, Sep 06, 2012 at 10:12:52PM +0200, Bruno Prémont wrote:
> On Thu, 06 September 2012 Emil Goode <emilgoode@...il.com> wrote:
> > The flush_delayed_work_sync function is deprecated,
> > we can instead call flush_delayed_work directly.
> >
> > Sparse is giving a warning:
> > drivers/hid/hid-picolcd_fb.c:611:2: warning:
> > ‘flush_delayed_work_sync’ is deprecated
> > (declared at include/linux/workqueue.h:454)
> > [-Wdeprecated-declarations]
> >
> > Signed-off-by: Emil Goode <emilgoode@...il.com>
>
> Acked-by: Bruno Prémont <bonbons@...ux-vserver.org>
>
> This matches a patch by Tejun a few weeks ago which was partially
> skipped in -next due to merge conflict with code split in picoLCD.
>
> See http://comments.gmane.org/gmane.linux.kernel.next/23740
>
> For the sake of proper bisectability, this should go in after
> Tejun's workqueue changes (if needed at all depending on how merge
> happens during pull by Linus).
Yeah, we either can ask Linus to fix it up during merge or send a
separate patch afterwards. In this case, I don't think it matters too
much either way. I tend to send out pull request fairly early in the
merge window, I'll try to remember to poke Linus about the merge
conflict.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists