linux-kernel - Re: [PATCH] slab: fix the DEADLOCK issue on l3 alien lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120906222933.GR2448@linux.vnet.ibm.com>
Date:	Thu, 6 Sep 2012 15:29:33 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Michael Wang <wangyun@...ux.vnet.ibm.com>
Cc:	Christoph Lameter <cl@...ux.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	Matt Mackall <mpm@...enic.com>,
	Pekka Enberg <penberg@...nel.org>
Subject: Re: [PATCH] slab: fix the DEADLOCK issue on l3 alien lock

On Thu, Sep 06, 2012 at 11:05:11AM +0800, Michael Wang wrote:
> On 09/05/2012 09:55 PM, Christoph Lameter wrote:
> > On Wed, 5 Sep 2012, Michael Wang wrote:
> > 
> >> Since the cachep and cachep->slabp_cache's l3 alien are in the same lock class,
> >> fake report generated.
> > 
> > Ahh... That is a key insight into why this occurs.
> > 
> >> This should not happen since we already have init_lock_keys() which will
> >> reassign the lock class for both l3 list and l3 alien.
> > 
> > Right. I was wondering why we still get intermitted reports on this.
> > 
> >> This patch will invoke init_lock_keys() after we done enable_cpucache()
> >> instead of before to avoid the fake DEADLOCK report.
> > 
> > Acked-by: Christoph Lameter <cl@...ux.com>
> 
> Thanks for your review.
> 
> And add Paul to the cc list(my skills on mailing is really poor...).

Tested-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/