linux-kernel - Re: [PATCH] UV: fix incorrect tlb flush all issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120906161136.b15e3d91.akpm@linux-foundation.org>
Date:	Thu, 6 Sep 2012 16:11:36 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alex Shi <alex.shi@...el.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com, cpw@....com,
	steiner@....com, jeremy.fitzhardinge@...rix.com,
	linux-kernel@...r.kernel.org, jbeulich@...e.com
Subject: Re: [PATCH] UV: fix incorrect tlb flush all issue

On Fri, 24 Aug 2012 16:57:35 +0800
Alex Shi <alex.shi@...el.com> wrote:

> The flush tlb optimization code has logical issue on UV platform.
> It doesn't flush the full range at all, since it simply
> ignores its 'end' parameter (and hence also the "all" indicator)
> in uv_flush_tlb_others() function.
> 
> This patch fixed this issue, but untested due to hardware leaking.

Well, it doesn't really come very close to being compilable:

arch/x86/platform/uv/tlb_uv.c: In function 'bau_process_message':
arch/x86/platform/uv/tlb_uv.c:283: error: 'struct bau_pq_entry' has no member named 'end'
arch/x86/platform/uv/tlb_uv.c:284: error: 'struct bau_pq_entry' has no member named 'start'

Cliff, could you please help out here?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/