linux-kernel - Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF+7xWko4wokuU-OiMYq3a2RJyaSb=qXM+LOpJCKHYpEB1Xi2Q@mail.gmail.com>
Date:	Fri, 7 Sep 2012 13:48:30 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Ryan Mallon <rmallon@...il.com>
Cc:	Hartley Sweeten <hsweeten@...ionengravers.com>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared

> Hi Axel,
>
> The patch looks fine. I notice that the other ep93xx boards are also
> using the SZ_ defines, but are indirectly including linux/sizes.h via
> asm/memory.h, which in turn is indirectly included via asm/io.h. That
Seems this is also true for other platforms ( e.g. mach-pxa, mach-ux500, etc)

> seems a bit flaky, so I wonder if we should just explicitly include
> <linux/sizes.h> in all the board files which use the SZ_ macros as per
> the patch below. Thoughts?
I'm 50/50 on this.
But if we do these changes, this patch is more than a build fix.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/