lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50499F3C.1070706@zytor.com>
Date:	Fri, 07 Sep 2012 00:16:12 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jan Beulich <JBeulich@...e.com>
CC:	mingo@...e.hu, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY

On 09/06/2012 11:48 PM, Jan Beulich wrote:
>
> --- 3.6-rc4/arch/x86/Kconfig.cpu
> +++ 3.6-rc4-x86-minimum-cpu-family/arch/x86/Kconfig.cpu
> @@ -409,9 +409,9 @@ config X86_CMOV
>   config X86_MINIMUM_CPU_FAMILY
>   	int
>   	default "64" if X86_64
> -	default "6" if X86_32 && X86_P6_NOP
> -	default "5" if X86_32 && X86_CMPXCHG64
> -	default "4" if X86_32 && (X86_XADD || X86_CMPXCHG || X86_BSWAP || X86_WP_WORKS_OK)
> +	default "6" if X86_P6_NOP || X86_CMOV
> +	default "5" if X86_CMPXCHG64 || X86_TSC
> +	default "4" if X86_XADD || X86_CMPXCHG || X86_BSWAP || X86_WP_WORKS_OK
>   	default "3"
>

Erk, this isn't right either.  We're not supposed to include 
CPUID-enumerable features here, so X86_CMOV, X86_CMPXCHG64 and X86_TSC 
don't belong, and should instead be done via required-features.h.

What a mess.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ