linux-kernel - Re: [PATCH] USB: XHCI: xhci-ring: Remove unused dma address calculation in inc_enq and inc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5049D07C.8010403@mvista.com>
Date:	Fri, 07 Sep 2012 14:46:20 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Girish Verma <girish@...cuitsutra.com>
CC:	kernel-janitors@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, sarah.a.sharp@...ux.intel.com,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH] USB: XHCI: xhci-ring: Remove unused dma address calculation
 in inc_enq and inc_deq function

Hello.

On 06-09-2012 19:47, Girish Verma wrote:

> Resending patch with latest kernel code:

    That comment should have been put after the --- tear line.

> In xhci-ring.c, function inc_enq and inc_deq calculate the dma address
> of trb but never used.



> Signed-off-by: Girish Verma <girish@...cuitsutra.com>
> ---
>   drivers/usb/host/xhci-ring.c |    4 ----
>   1 files changed, 0 insertions(+), 4 deletions(-)

> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 643c2f3..5c5c47b 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -145,7 +145,6 @@ static void next_trb(struct xhci_hcd *xhci,
>    */
>   static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring)
>   {
> -	unsigned long long addr;
>
>   	ring->deq_updates++;
>
> @@ -176,7 +175,6 @@ static void inc_deq(struct xhci_hcd *xhci, struct
> xhci_ring *ring)
>   		}
>   	} while (last_trb(xhci, ring, ring->deq_seg, ring->dequeue));
>
> -	addr = (unsigned long long) xhci_trb_virt_to_dma(ring->deq_seg,
> ring->dequeue);
>   }
>
>   /*
> @@ -201,7 +199,6 @@ static void inc_enq(struct xhci_hcd *xhci, struct
> xhci_ring *ring,
>   {
>   	u32 chain;
>   	union xhci_trb *next;
> -	unsigned long long addr;
>
>   	chain = le32_to_cpu(ring->enqueue->generic.field[3]) & TRB_CHAIN;
>   	/* If this is not event ring, there is one less usable TRB */
> @@ -253,7 +250,6 @@ static void inc_enq(struct xhci_hcd *xhci, struct
> xhci_ring *ring,
>   		ring->enqueue = ring->enq_seg->trbs;
>   		next = ring->enqueue;
>   	}
> -	addr = (unsigned long long) xhci_trb_virt_to_dma(ring->enq_seg,
> ring->enqueue);

    The patch is line wrapped. Should be easy to fix by hand when applying 
though...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/