linux-kernel - Re: 3.4.10 N_GSM tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3627qt7kn.fsf@t19.piap.pl>
Date:	Fri, 07 Sep 2012 13:07:20 +0200
From:	khalasa@...p.pl (Krzysztof Hałasa)
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: 3.4.10 N_GSM tty_io WARNING and lockup

Alan Cox <alan@...rguk.ukuu.org.uk> writes:

>> I'm trying to use GSM tty line discipline. Basically
>> 
>> echo AT+CMUX=0 > /dev/ttyS0
>> 
>> set termios (speed etc.)
>> int ldisc = N_GSM0710;
>> ioctl(fd, TIOCSETD, &ldisc);
>
> Baffled at this point. If you set some other ldisc instead (eg PPP) can
> you reproduce it the same way ?

In the meantime I've rebased to v3.5.3 and it started to work. Do you
think it is worth it investigating v3.4.10 at this point?

This is Atheros AR71xx based RouterStation Pro board (MIPS). I'm using
several patches supporting this board, though I can't see anything
relevant to serial/tty, except maybe the following (which is IMHO not
the problem source either):

@@ -1941,17 +1941,20 @@ static int serial8250_startup(struct uart_port *port)
	if (port->type == PORT_16C950) {
 		/* Wake up and initialize UART */
-		up->acr = 0;
+		up->acr = UART_ACR_RTS_485;
+		serial_icr_write(up, UART_ACR, up->acr);
 		serial_port_out(port, UART_LCR, UART_LCR_CONF_MODE_B);
 		serial_port_out(port, UART_EFR, UART_EFR_ECB);
 		serial_port_out(port, UART_IER, 0);
 		serial_port_out(port, UART_LCR, 0);
+#if 0
 		serial_icr_write(up, UART_CSR, 0); /* Reset the UART */
 		serial_port_out(port, UART_LCR, UART_LCR_CONF_MODE_B);
 		serial_port_out(port, UART_EFR, UART_EFR_ECB);
 		serial_port_out(port, UART_LCR, 0);
+#endif

Anyway the patchsets are almost identical with both kernel versions.
-- 
Krzysztof Halasa

Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/