linux-kernel - Re: [PATCH 00/19] First HREF Device Tree enablement patch-set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201209071241.17198.arnd@arndb.de>
Date:	Fri, 7 Sep 2012 12:41:16 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com
Subject: Re: [PATCH 00/19] First HREF Device Tree enablement patch-set

On Friday 07 September 2012, Lee Jones wrote:
> Based on v3.6-rc4
> 
> This patch consists of Device Tree related enablement for
> ST-Ericsson's development HREF hardware reference board.
> Most devices are very similar, if not the same to the
> previously enabled Snowball low-cost development board.
> These are referenced from the relevant .dtsi file and
> merely enabled in the HREF specific Device Tree. There 
> are also one or two minor Device Tree related fixes which
> were stumbled upon along the way.

The patches basically look good to me (except patch 15, see
comment there), but they are not ordered in a way that allows
bisection. I can see two ways to do this better:

a) first do all the code changes, one by one, then add the
fully populated device tree in the last patch.

b) as commented on patch 5, atomically change over each
device in both the DT source and the board code.
Also do the driver changes (i2c, tc3589x) before changing
them in the device tree.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/