linux-kernel - Re: [PATCH] procfs: don't need a PATH_MAX allocation to hold a string representation of an int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120907084814.07a59c98@corrin.poochiereds.net>
Date:	Fri, 7 Sep 2012 08:48:14 -0400
From:	Jeff Layton <jlayton@...chiereds.net>
To:	viro@...iv.linux.org.uk
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] procfs: don't need a PATH_MAX allocation to hold a
 string representation of an int

On Fri,  7 Sep 2012 08:34:53 -0400
Jeff Layton <jlayton@...hat.com> wrote:

> Signed-off-by: Jeff Layton <jlayton@...hat.com>
> ---
>  fs/proc/base.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 1b6c84c..58e801b 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2758,7 +2758,8 @@ static void *proc_self_follow_link(struct dentry *dentry, struct nameidata *nd)
>  	pid_t tgid = task_tgid_nr_ns(current, ns);
>  	char *name = ERR_PTR(-ENOENT);
>  	if (tgid) {
> -		name = __getname();
> +		/* 10 for max length of an int in decimal + NULL terminator */
> +		name = kmalloc(11, GFP_KERNEL);

		^^^^^
Bah...my mistake. This should be "12", since it's possible (though
unlikely) that this value could be negative. Is there a better way to
express "strlen of max representation of an int in decimal" ?

>  		if (!name)
>  			name = ERR_PTR(-ENOMEM);
>  		else
> @@ -2773,7 +2774,7 @@ static void proc_self_put_link(struct dentry *dentry, struct nameidata *nd,
>  {
>  	char *s = nd_get_link(nd);
>  	if (!IS_ERR(s))
> -		__putname(s);
> +		kfree(s);
>  }
>  
>  static const struct inode_operations proc_self_inode_operations = {


-- 
Jeff Layton <jlayton@...chiereds.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/