linux-kernel - Re: [PATCH 4/6] unicore32: Add common clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120907125328.GB29340@avionic-0098.mockup.avionic-design.de>
Date:	Fri, 7 Sep 2012 14:53:28 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	guanxuetao@...c.pku.edu.cn
Cc:	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] unicore32: Add common clock support

On Thu, Sep 06, 2012 at 04:42:06PM +0800, guanxuetao@...c.pku.edu.cn wrote:
> > This commit adds support for the common clock framework to the Unicore32
> > architecture.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
> 
> This patch can't work.
> Could you disintegrate it into several small patches, so I could check it
> out.

I don't understand. How do you mean it can't work? Are you saying the
patch doesn't build, or does the system no longer boot properly? I don't
see how splitting it into smaller pieces is going to change anything
about that. Splitting it up also isn't going to work very well.
Conversion to the common clock framework is really all or nothing.

Thierry

Content of type "application/pgp-signature" skipped