linux-kernel - Re: [PATCH 1/3] tools lib traceevent: Get rid of die() from pretty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1347028684.8178.5.camel@gandalf.local.home>
Date:	Fri, 07 Sep 2012 10:38:04 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH 1/3] tools lib traceevent: Get rid of die() from
 pretty_print()

On Fri, 2012-09-07 at 11:49 +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
> 
> There are three cases that call die() in the pretty_print.
> 
>  1. insufficient number of argument: cannot proceed anymore.
>  2. too long format conversion specifier: truncate and proceed.
>  3. bad size specifier in format string: skip and proceed.
> 
> For all cases, convert die to do_warning, mark the event as
> EVENT_FL_FAILED and print error message at the last.
> 
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Thanks Namyung!

Arnaldo,

Please add my "Acked-by: Steven Rostedt <rostedt@...dmis.org>" to all
three of these patches.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/