linux-kernel - Re: [ 16/32] ext4: make sure the journal sb is written in ext4_clear_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1346986512.17321.42.camel@deadeye.wl.decadent.org.uk>
Date:	Fri, 07 Sep 2012 03:55:12 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Theodore Tso <tytso@....edu>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 16/32] ext4: make sure the journal sb is written in
 ext4_clear_journal_err()

On Sun, 2012-08-19 at 20:57 -0700, Greg Kroah-Hartman wrote:
> From: Greg KH <gregkh@...uxfoundation.org>
> 
> 3.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Theodore Ts'o <tytso@....edu>
> 
> commit d796c52ef0b71a988364f6109aeb63d79c5b116b upstream.
> 
> After we transfer set the EXT4_ERROR_FS bit in the file system
> superblock, it's not enough to call jbd2_journal_clear_err() to clear
> the error indication from journal superblock --- we need to call
> jbd2_journal_update_sb_errno() as well.  Otherwise, when the root file
> system is mounted read-only, the journal is replayed, and the error
> indicator is transferred to the superblock --- but the s_errno field
> in the jbd2 superblock is left set (since although we cleared it in
> memory, we never flushed it out to disk).
> 
> This can end up confusing e2fsck.  We should make e2fsck more robust
> in this case, but the kernel shouldn't be leaving things in this
> confused state, either.
[...]

Is this needed for 3.2?  It looked like it depended on
24bcc89c7e7c64982e6192b4952a0a92379fc341 which is strictly too big a
change for a stable series.  But perhaps there's a way to avoid that
dependency.

Ben.

-- 
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
                      - Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)