[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120907153349.GC19165@ghostprotocols.net>
Date: Fri, 7 Sep 2012 08:33:49 -0700
From: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@...il.com>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
Andi Kleen <andi@...stfloor.org>,
David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 07/12] perf diff: Add ratio computation way to compare
hist entries
Em Fri, Sep 07, 2012 at 02:45:28PM +0900, Namhyung Kim escreveu:
> On Thu, 6 Sep 2012 17:47:01 +0200, Jiri Olsa wrote:
> > @@ -263,6 +296,8 @@ static const struct option options[] = {
> > + OPT_STRING('c', "compute", &compute_str, "delta,ratio (default delta)",
> > + "Entries differential computation selection"),
>
> Why not make it OPT_CALLBACK?
Namhyung, please trim the message to contain just the snippet that is
related to your comment,
Thanks,
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists