linux-kernel - Re: [PATCH 06/11] target: go through normal processing for zero-length REQUEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504A5A51.5060609@redhat.com>
Date:	Fri, 07 Sep 2012 22:34:25 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
CC:	linux-kernel@...r.kernel.org, target-devel@...r.kernel.org,
	hch@....de, roland@...nel.org
Subject: Re: [PATCH 06/11] target: go through normal processing for zero-length
 REQUEST_SENSE

Il 07/09/2012 20:33, Nicholas A. Bellinger ha scritto:
>>> > >  	if (!cmd->data_length &&
>>> > > +	    cmd->t_task_cdb[0] != REQUEST_SENSE &&
>>> > >  	    (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV ||
>>> > >  	     cmd->t_task_cdb[0] == REPORT_LUNS) {
>>> > >  		spin_lock_irq(&cmd->t_state_lock);
> Btw, this section does not compile.

The idea was to add the missing parenthesis to

cmd->t_task_cdb[0] == REPORT_LUNS))

but your fix is also correct after patch 3.

Thanks!

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/