linux-kernel - Re: [PATCH RESEND]mm/ia64: fix a node distance bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1209071558430.28027@chino.kir.corp.google.com>
Date:	Fri, 7 Sep 2012 15:58:59 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	wujianguo <wujianguo106@...il.com>
cc:	tony.luck@...el.com, akpm@...ux-foundation.org,
	fenghua.yu@...el.com, linux-ia64@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	jiang.liu@...wei.com, guohanjun@...wei.com, qiuxishi@...wei.com,
	wujianguo@...wei.com, wency@...fujitsu.com
Subject: Re: [PATCH RESEND]mm/ia64: fix a node distance bug

On Thu, 6 Sep 2012, wujianguo wrote:

> From: Jianguo Wu <wujianguo@...wei.com>
> 
> In arch ia64, has following definition:
> extern u8 numa_slit[MAX_NUMNODES * MAX_NUMNODES];
> #define node_distance(from,to) (numa_slit[(from) * num_online_nodes() + (to)])
> 
> num_online_nodes() is a variable value, it can be changed after hot-remove/add
> a node.
> 
> I my practice, I found node distance is wrong after offline
> a node in IA64 platform. For example system has 4 nodes:
> node distances:
> node   0   1   2   3
>   0:  10  21  21  32
>   1:  21  10  32  21
>   2:  21  32  10  21
>   3:  32  21  21  10
> 
> linux-drf:/sys/devices/system/node/node0 # cat distance
> 10  21  21  32
> linux-drf:/sys/devices/system/node/node1 # cat distance
> 21  10  32  21
> 
> After offline node2:
> linux-drf:/sys/devices/system/node/node0 # cat distance
> 10 21 32
> linux-drf:/sys/devices/system/node/node1 # cat distance
> 32 21 32	--------->expected value is: 21  10  21
> 
> 
> Signed-off-by: Jianguo Wu <wujianguo@...wei.com>
> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/