linux-kernel - Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120908125059.GG20401@ghostprotocols.net>
Date:	Sat, 8 Sep 2012 05:50:59 -0700
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Namhyung Kim <namhyung@...nel.org>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

Em Sat, Sep 08, 2012 at 02:35:14PM +0200, Jiri Olsa escreveu:
> On Fri, Sep 07, 2012 at 11:55:02AM +0900, Namhyung Kim wrote:
> > Hi, Jiri
> > 
> > On Thu,  6 Sep 2012 17:46:59 +0200, Jiri Olsa wrote:
> > > Currently for any of the data columns (like Overhead/Period..) in
> > > stdio ui, there's separate code to print header/dots/value scattered
> > > along the display code path.
> > >
> > > Adding hists_stdio_column struct to centralize all info needed
> > > to print column header/dots/value.
> > >
> > > This change eases up addition for new columns, which is now mostly
> > > matter only of adding new hists_stdio_column struct.
> > 
> > As you may know, I submitted a similar patchset few days ago for the
> > same reason and it handles TUI/GTK cases as well.  I'm waiting for
> > reviews.
> 
> ok, I'll rebase this to acme/tmp.perf/hpp

well, you can, but that one is buggy and you will not be able to test
'perf diff' at all...

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/