linux-kernel - Re: [PATCH v2 05/12] perf tools: include basename for non-glibc systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504B574E.40907@gmail.com>
Date:	Sat, 08 Sep 2012 08:33:50 -0600
From:	David Ahern <dsahern@...il.com>
To:	Pekka Enberg <penberg@...nel.org>
CC:	Irina Tirdea <irina.tirdea@...il.com>, mingo@...hat.com,
	acme@...stprotocols.net, a.p.zijlstra@...llo.nl,
	rostedt@...dmis.org, paulus@...ba.org, namhyung.kim@....com,
	linux-kernel@...r.kernel.org, Irina Tirdea <irina.tirdea@...el.com>
Subject: Re: [PATCH v2 05/12] perf tools: include basename for non-glibc systems

On 9/8/12 3:09 AM, Pekka Enberg wrote:
> It's safe to include <libgen.h> on glibc Linux systems as well, no? So
> there's no need to check for __BIONIC__.

Theoretically, yes. In reality compile fails in multiple places. 
basename can modify the string passed to it and several places in perf 
are passing a string marked const. Oops. I'll fix those places and 
remove the BIONIC conditional for libgen.h

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/