linux-kernel - Re: [PATCH 5/7] uprobes: Do not (ab)use TIF_SINGLESTEP/user_*_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120908074904.GS30238@linux.vnet.ibm.com>
Date:	Sat, 8 Sep 2012 13:19:04 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <anton@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Roland McGrath <roland@...k.frob.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] uprobes: Do not (ab)use
 TIF_SINGLESTEP/user_*_single_step() for single-stepping

* Oleg Nesterov <oleg@...hat.com> [2012-09-07 17:50:57]:

> On 09/07, Srikar Dronamraju wrote:
> >
> > Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> 
> Thanks!
> 
> (and thanks, I'll fix the typo in 2/7 you pointed out)
> 
> > >  void arch_uprobe_enable_step(struct arch_uprobe *auprobe)
> > >  {
> > > -	struct uprobe_task	*utask		= current->utask;
> > > -	struct arch_uprobe_task	*autask		= &utask->autask;
> > > +	struct task_struct *task = current;
> >
> > Any particular reason to use task instead of current?
> 
> No particular reason, and I think in this case asm will be the same.
> 
> Please let me know if you prefer to remove this variable, I'll redo
> this patch.

No, the patch is fine.

I have no problem with the additional variable, I was just curious if
you had any other plans that needed that a exta variable that alls.

-- 
thanks and regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/