linux-kernel - Re: [PATCH v2 03/12] perf tools: include _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLHCavYZQCOZP0nw0ig9uFx0wbR5UP23zKa0gXvmpFvNDg@mail.gmail.com>
Date:	Sat, 8 Sep 2012 12:07:07 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Irina Tirdea <irina.tirdea@...il.com>
Cc:	mingo@...hat.com, acme@...stprotocols.net, a.p.zijlstra@...llo.nl,
	rostedt@...dmis.org, paulus@...ba.org, dsahern@...il.com,
	namhyung.kim@....com, linux-kernel@...r.kernel.org,
	Irina Tirdea <irina.tirdea@...el.com>
Subject: Re: [PATCH v2 03/12] perf tools: include __WORDSIZE definition

On Sat, Sep 8, 2012 at 3:43 AM, Irina Tirdea <irina.tirdea@...il.com> wrote:
> From: Irina Tirdea <irina.tirdea@...el.com>
>
> __WORDSIZE is GLibC-specific and is not defined on all systems or glibc
> versions (e.g. Android's bionic does not define it).
>
> In file included from util/include/linux/bitmap.h:5:0,
>                  from util/header.h:10,
>                  from util/session.h:6,
>                  from util/build-id.h:4,
>                  from util/annotate.c:11:
> util/include/linux/bitops.h: In function 'set_bit':
> util/include/linux/bitops.h:25:12: error:
> '__WORDSIZE' undeclared (first use in this function)
> util/include/linux/bitops.h:25:12: note:
> each undeclared identifier is reported only once for each function it appears in
> util/include/linux/bitops.h:23:51: error:
> parameter 'addr' set but not used [-Werror=unused-but-set-parameter]
> util/include/linux/bitops.h: In function 'clear_bit':
> util/include/linux/bitops.h:30:12: error:
> '__WORDSIZE' undeclared (first use in this function)
> util/include/linux/bitops.h:28:53: error:
> parameter 'addr' set but not used [-Werror=unused-but-set-parameter]
> In file included from util/header.h:10:0,
>                  from util/session.h:6,
>                  from util/build-id.h:4,
>                  from util/annotate.c:11:
> util/include/linux/bitmap.h: In function 'bitmap_zero':
> util/include/linux/bitmap.h:22:6: error:
> '__WORDSIZE' undeclared (first use in this function)
>
> Defining __WORDSIZE in perf's headers if it is not already defined.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@...el.com>
> ---
>  tools/perf/util/include/linux/bitops.h |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tools/perf/util/include/linux/bitops.h b/tools/perf/util/include/linux/bitops.h
> index 587a230..91779ec 100644
> --- a/tools/perf/util/include/linux/bitops.h
> +++ b/tools/perf/util/include/linux/bitops.h
> @@ -5,6 +5,15 @@
>  #include <linux/compiler.h>
>  #include <asm/hweight.h>
>
> +#ifndef __WORDSIZE
> +#if defined(__x86_64__)
> +# define __WORDSIZE 64
> +#endif
> +#if defined(__i386__) || defined(__arm__)
> +# define __WORDSIZE 32
> +#endif
> +#endif

Why not use "sizeof(unsigned long) * 8" ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/