linux-kernel - Re: [PATCH 4/7 V6] workqueue: fix idle worker depletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120909063031.GA15530@dhcp-172-17-108-109.mtv.corp.google.com>
Date:	Sat, 8 Sep 2012 23:30:31 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <eag0628@...il.com>
Cc:	Lai Jiangshan <laijs@...fujitsu.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7 V6] workqueue: fix idle worker depletion

Hello, Lai.

On Sun, Sep 09, 2012 at 12:09:58PM +0800, Lai Jiangshan wrote:
> >         mutex_lock(&pool->manager_mutex);
> >         if (worker_maybe_bind_and_lock(worker))
> >                 worker_clr_flags(worker, WORKER_UNBOUND);
> >         ret = true;
> >
> 
> 
> This code is correct. worker_maybe_bind_and_lock() can be called any time.
> but I like to call it only when it is really needed.

Ummm... that code is complex for no reason.  It isn't easier to read
or better in any way.  Given the recent exchanges, it seems our tastes
differ greatly.  Can you please just refresh the two patches as
requested and repost them on top of for-3.6-fixes?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/