linux-kernel - Re: [RFC][PATCH] libata: enable SATA disk fua detection on default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 09 Sep 2012 16:39:06 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Arvydas Sidorenko <asido4@...il.com>
CC:	Michael Tokarev <mjt@....msk.ru>, Jeff Garzik <jeff@...zik.org>,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	linux-scsi@...r.kernel.org, Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [RFC][PATCH] libata: enable SATA disk fua detection on default

On 09/09/2012 04:34 PM, Arvydas Sidorenko wrote:
>> Meanwhile there already has a number of SATA disks that have supported
>> this feature.  So I think maybe we can enable it.
>>
>> Regards,
>> Zheng
>
> Blindly enabling FUA by default in my opinion is not a good idea at all.
> I believe the focus should be on detecting FUA support on the device
> instead, which the kernel at this point cannot reliably do (is it possible?).

Premature assumptions.  It is entirely possible that FUA is detected 
accurately, but the software is missing a flush somewhere that FUA 
requires, if disks are to be used in FUA mode.

The filesystem and the block layer must properly generate and order 
their I/Os based on the FUA enablement bits that appear in the block 
layer after libata discovers the SATA FUA feature.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/