linux-kernel - Re: [PATCH 2/2] backlight: add new lm3639 backlight driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Sep 2012 16:13:12 +0900
From:	gshark <gshark.jeong@...il.com>
To:	Randy Dunlap <rdunlap@...otime.net>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Daniel Jeong <daniel.jeong@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] backlight: add new lm3639 backlight driver


LM3639 has not only pins for backlihgt but also pins for LEDs. So it 
uses functions in led_class and led_core file.
When I see your config file, "randconig", you set CONFIG_NEW_LEDS=y but 
you didn't set CONFIG_LEDS_CLASS.
We need to set CONFIG_NEW_LEDS and CONFIG_LEDS_CLASS both to compile it.
To fix it, I added  two reverse dependencies "select NEW_LEDS" and 
"select CONFIG_LEDS_CLASS".

2012년 09월 10일 14:28, Randy Dunlap 쓴 글:
> On 09/09/2012 08:16 PM, G.Shark Jeong wrote:
>
>> From: "G.Shark Jeong" <gshark.jeong@...il.com>
>>
>> This driver is a general version for LM3639 backlgiht driver chip of TI.
>>
>> Put NEW_LEDS and LEDS_CLASS into Kconfig file to reduce additional configuration works in LEDs.
>>
>> www.ti.com
>
> eh?
>
>> Signed-off-by: G.Shark Jeong <gshark.jeong@...il.com>
>
> Linus has asked patch committers to use Reported-by when appropriate.
>
> Reported-by: Randy Dunlap <rdunlap@...otime.net>
> Acked-by: Randy Dunlap <rdunlap@...otime.net>
>
>
>> ---
>>   drivers/video/backlight/Kconfig |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
>> index 2ed68bd..e6c78cd 100644
>> --- a/drivers/video/backlight/Kconfig
>> +++ b/drivers/video/backlight/Kconfig
>> @@ -356,6 +356,8 @@ config BACKLIGHT_LM3639
>>   	tristate "Backlight Driver for LM3639"
>>   	depends on BACKLIGHT_CLASS_DEVICE && I2C
>>   	select REGMAP_I2C
>> +	select NEW_LEDS
>> +	select LEDS_CLASS
>>   	help
>>   	  This supports TI LM3639 Backlight + 1.5A Flash LED Driver
>>   
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/