linux-kernel - Re: [PATCH 1/2] iio: inkern: clear allocated memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504DAF19.3050701@jic23.retrosnub.co.uk>
Date:	Mon, 10 Sep 2012 10:12:57 +0100
From:	Jonathan Cameron <jic23@...23.retrosnub.co.uk>
To:	"Kim, Milo" <Milo.Kim@...com>
CC:	Jonathan Cameron <jic23@...nel.org>,
	Jonathan Cameron <jic23@....ac.uk>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] iio: inkern: clear allocated memory

On 10/09/12 09:02, Kim, Milo wrote:
>   Use kzalloc() rathern than kmalloc() for initializing iio_dev and
>   iio_chan_spec.
Please state why.  I'm sure I can track it down, but it ought to be
in the commit comment.
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
> ---
>   drivers/iio/inkern.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index b5afc2f..1faa240 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -130,7 +130,7 @@ struct iio_channel *iio_channel_get(const char *name, const char *channel_name)
>   	if (c == NULL)
>   		return ERR_PTR(-ENODEV);
>
> -	channel = kmalloc(sizeof(*channel), GFP_KERNEL);
> +	channel = kzalloc(sizeof(*channel), GFP_KERNEL);
>   	if (channel == NULL)
>   		return ERR_PTR(-ENOMEM);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/