linux-kernel - Re: [ 12/95] xhci: Switch PPT ports to EHCI on shutdown.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Sep 2012 16:18:26 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Denis Turischev <denis@...pulab.co.il>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Robert Hancock <hancockrwd@...il.com>
Subject: Re: [ 12/95] xhci: Switch PPT ports to EHCI on shutdown.

On Mon, 2012-09-10 at 14:09 +0300, Denis Turischev wrote:
> Hi Ben,
> 
> As reported by Robert Hancock there is a typo in if statement below.
> Do you want I resubmit it? Or should we wait for Sarah Sharp review?
[...]
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -648,6 +648,9 @@ void xhci_shutdown(struct usb_hcd *hcd)
> >  {
> >  	struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> >  
> > +	if (xhci->quirks && XHCI_SPURIOUS_REBOOT)
> 
> 
> This looks like a typo, think it should be & not &&. With this code, it
> appears the quirk will always be triggered since XHCI_SPURIOUS_REBOOT is
> non-zero.
[...]

As the typo is not fixed in mainline, I can't fix it in 3.2.y yet.  So
I'll defer this until that happens.

Thanks for your review.

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an expert.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)