linux-kernel - Re: [PATCH v3 08/31] arm64: CPU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120910164328.GA8238@arm.com>
Date:	Mon, 10 Sep 2012 17:43:28 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 08/31] arm64: CPU support

On Fri, Sep 07, 2012 at 08:24:38PM +0100, Arnd Bergmann wrote:
> On Friday 07 September 2012, Catalin Marinas wrote:
> > +#include <asm/cputable.h>
> > +
> > +extern unsigned long __cpu_setup(void);
> > +
> > +struct cpu_info __initdata cpu_table[] = {
> > +	{
> > +		.cpu_id_val	= 0x000f0000,
> > +		.cpu_id_mask	= 0x000f0000,
> > +		.cpu_name	= "AArch64 Processor",
> > +		.cpu_setup	= __cpu_setup,
> > +	},
> > +	{ /* Empty */ },
> > +};
> 
> > +#define MAIR(attr, mt)	((attr) << ((mt) * 8))
> > +
> > +ENTRY(cpu_proc_init)
> > +	ret
> > +ENDPROC(cpu_proc_init)
> > +
> > +ENTRY(cpu_proc_fin)
> > +	ret
> > +ENDPROC(cpu_proc_fin)
> 
> 
> These seem to be leftovers from multi-cpu support that can be removed.

Actually cpu_proc_fin() needs to be implemented for turning the caches
off during setup_restart(). But I'll rename it to something more
meaningful like cpu_cache_off(). The other can go.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/